nvme: let dm-mpath distinguish nvme error codes
authorJunxiong Guan <guanjunxiong@huawei.com>
Fri, 21 Apr 2017 10:59:07 +0000 (12:59 +0200)
committerChristoph Hellwig <hch@lst.de>
Fri, 21 Apr 2017 14:41:56 +0000 (16:41 +0200)
Currently most IOs which return the nvme error codes are retried on
the other path if those IOs returns EIO from NVMe driver. This
patch let Multipath distinguish nvme media error codes and some
generic or cmd-specific nvme error codes so that multipath will
not retry those kinds of IO, to save bandwidth.

Signed-off-by: Junxiong Guan <guanjunxiong@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index 8dc6647982936ee071d0a28f5e5c2fb69f5980fb..263946b23628e1273dfccef7e4936e8fc6de4a01 100644 (file)
@@ -75,6 +75,20 @@ static int nvme_error_status(struct request *req)
                return -ENOSPC;
        default:
                return -EIO;
+
+       /*
+        * XXX: these errors are a nasty side-band protocol to
+        * drivers/md/dm-mpath.c:noretry_error() that aren't documented
+        * anywhere..
+        */
+       case NVME_SC_CMD_SEQ_ERROR:
+               return -EILSEQ;
+       case NVME_SC_ONCS_NOT_SUPPORTED:
+               return -EOPNOTSUPP;
+       case NVME_SC_WRITE_FAULT:
+       case NVME_SC_READ_ERROR:
+       case NVME_SC_UNWRITTEN_BLOCK:
+               return -ENODATA;
        }
 }