PCI,parisc: Enable 64-bit bus addresses on PA-RISC
authorHelge Deller <deller@gmx.de>
Wed, 2 Sep 2015 16:17:29 +0000 (18:17 +0200)
committerHelge Deller <deller@gmx.de>
Tue, 8 Sep 2015 13:30:47 +0000 (15:30 +0200)
Commit 3a9ad0b ("PCI: Add pci_bus_addr_t") unconditionally introduced usage of
64-bit PCI bus addresses on all 64-bit platforms which broke PA-RISC.

It turned out that due to enabling the 64-bit addresses, the PCI logic decided
to use the GMMIO instead of the LMMIO region. This commit simply disables
registering the GMMIO and thus we fall back to use the LMMIO region as before.

Reverts commit 45ea2a5fed6dacb9bb0558d8b21eacc1c45d5bb4
("PCI: Don't use 64-bit bus addresses on PA-RISC")

To: linux-parisc@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Meelis Roos <mroos@linux.ee>
Cc: stable@vger.kernel.org # v3.19+
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/parisc/lba_pci.c
drivers/pci/Kconfig

index 901e1a3fa4e2689e6cfd31a01d01a80520dc3a22..7b9e89ba0465f120b07385643b56900a61054696 100644 (file)
@@ -1555,8 +1555,11 @@ lba_driver_probe(struct parisc_device *dev)
        if (lba_dev->hba.lmmio_space.flags)
                pci_add_resource_offset(&resources, &lba_dev->hba.lmmio_space,
                                        lba_dev->hba.lmmio_space_offset);
-       if (lba_dev->hba.gmmio_space.flags)
-               pci_add_resource(&resources, &lba_dev->hba.gmmio_space);
+       if (lba_dev->hba.gmmio_space.flags) {
+               /* pci_add_resource(&resources, &lba_dev->hba.gmmio_space); */
+               pr_warn("LBA: Not registering GMMIO space %pR\n",
+                       &lba_dev->hba.gmmio_space);
+       }
 
        pci_add_resource(&resources, &lba_dev->hba.bus_num);
 
index 944f50015ed07b41b2de0da464812910c411cc1a..73de4efcbe6edc85c8f3fb54e0c925a7ab30492b 100644 (file)
@@ -2,7 +2,7 @@
 # PCI configuration
 #
 config PCI_BUS_ADDR_T_64BIT
-       def_bool y if (ARCH_DMA_ADDR_T_64BIT || (64BIT && !PARISC))
+       def_bool y if (ARCH_DMA_ADDR_T_64BIT || 64BIT)
        depends on PCI
 
 config PCI_MSI