mtd: physmap_of: Correct the size argument to kzalloc
authorJulia Lawall <julia@diku.dk>
Tue, 29 Dec 2009 19:15:23 +0000 (20:15 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Sat, 2 Jan 2010 10:04:56 +0000 (10:04 +0000)
mtd_list has type struct mtd_info **, not struct mtd_info *, so the
elements of the array should have pointer type, not structure type.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@disable sizeof_type_expr@
type T;
T **x;
@@

  x =
  <+...sizeof(
- T
+ *x
  )...+>
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/maps/physmap_of.c

index 61e4eb48bb2d5a37dfad765e3399e3b22d6270f9..1d91333010b162563bbed0fa295a1850dbce9e8d 100644 (file)
@@ -217,7 +217,7 @@ static int __devinit of_flash_probe(struct of_device *dev,
 
        dev_set_drvdata(&dev->dev, info);
 
-       mtd_list = kzalloc(sizeof(struct mtd_info) * count, GFP_KERNEL);
+       mtd_list = kzalloc(sizeof(*mtd_list) * count, GFP_KERNEL);
        if (!mtd_list)
                goto err_flash_remove;