cxl: make base more explicitly non-modular
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Sun, 3 Jul 2016 20:31:53 +0000 (16:31 -0400)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 8 Jul 2016 12:22:58 +0000 (22:22 +1000)
The Kconfig/Makefile currently controlling compilation of this code is:

drivers/misc/cxl/Kconfig:config CXL_BASE
drivers/misc/cxl/Kconfig:       bool

drivers/misc/cxl/Makefile:obj-$(CONFIG_CXL_BASE)          += base.o

...meaning that it currently is not being built as a module by anyone.

Lets convert the one module_init into device_initcall so that
when reading the driver it more clear that it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We don't replace module.h with init.h since the file is doing
other modular stuff (module_get/put) even though it is built-in.

Cc: Ian Munsie <imunsie@au1.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/misc/cxl/base.c

index 9b90ec6c07cd78fa3047ef3e39ba1626a318e8f3..e6f49aca0035b31e86d9b38fa5771abc78677731 100644 (file)
@@ -114,5 +114,4 @@ static int __init cxl_base_init(void)
        pr_devel("Found %d cxl device(s)\n", count);
        return 0;
 }
-
-module_init(cxl_base_init);
+device_initcall(cxl_base_init);