projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: c1f1f66)
cw1200: Delete an unnecessary check before the function call "release_firmware"
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 4 Feb 2015 15:32:15 +0000 (16:32 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 6 Feb 2015 06:47:40 +0000 (08:47 +0200)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/cw1200/fwio.c patch | blob | blame | history

diff --git a/drivers/net/wireless/cw1200/fwio.c b/drivers/net/wireless/cw1200/fwio.c
index 6f1b9aace8b340cea12555bb2dd1eaf777c54d96..581dfdedd436f2f9c66c82e3312b59508f3f1a10 100644 (file)
--- a/drivers/net/wireless/cw1200/fwio.c
+++ b/drivers/net/wireless/cw1200/fwio.c
@@ -246,8 +246,7 @@ static int cw1200_load_firmware_cw1200(struct cw1200_common *priv)
 
 error:
        kfree(buf);
-       if (firmware)
-               release_firmware(firmware);
+       release_firmware(firmware);
        return ret;
 
 #undef APB_WRITE