KVM: MMU: use kvm_sync_page in kvm_sync_pages
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 24 Feb 2016 09:19:30 +0000 (10:19 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 8 Mar 2016 11:33:20 +0000 (12:33 +0100)
If the last argument is true, kvm_unlink_unsync_page is called anyway in
__kvm_sync_page (either by kvm_mmu_prepare_zap_page or by __kvm_sync_page
itself).  Therefore, kvm_sync_pages can just call kvm_sync_page, instead
of going through kvm_unlink_unsync_page+__kvm_sync_page.

Reviewed-by: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu.c

index 45a8a0605a0990a1f21fcfe13b73d900be1c64b8..56be337140365934f0baea7bdb933c81c7ae6daf 100644 (file)
@@ -1987,8 +1987,7 @@ static void kvm_sync_pages(struct kvm_vcpu *vcpu,  gfn_t gfn)
                        continue;
 
                WARN_ON(s->role.level != PT_PAGE_TABLE_LEVEL);
-               kvm_unlink_unsync_page(vcpu->kvm, s);
-               if (!__kvm_sync_page(vcpu, s, &invalid_list, false))
+               if (!kvm_sync_page(vcpu, s, &invalid_list))
                        flush = true;
        }