drivers/isdn/hardware/mISDN: move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Fri, 9 Jan 2009 10:22:53 +0000 (10:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 11 Jan 2009 08:06:34 +0000 (00:06 -0800)
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/mISDN/hfcmulti.c

index 97f4708b38795fe030fc6e92d3004697edc44c9b..595ba8eb4a07a2f534eb387f82d425d79ea0ee29 100644 (file)
@@ -3615,7 +3615,7 @@ hfcm_bctrl(struct mISDNchannel *ch, u_int cmd, void *arg)
 static void
 ph_state_change(struct dchannel *dch)
 {
-       struct hfc_multi *hc = dch->hw;
+       struct hfc_multi *hc;
        int ch, i;
 
        if (!dch) {
@@ -3623,6 +3623,7 @@ ph_state_change(struct dchannel *dch)
                    __func__);
                return;
        }
+       hc = dch->hw;
        ch = dch->slot;
 
        if (hc->type == 1) {