drm/vc4: remove redundant ret status check
authorColin Ian King <colin.king@canonical.com>
Sat, 9 Jul 2016 22:26:03 +0000 (23:26 +0100)
committerEric Anholt <eric@anholt.net>
Tue, 12 Jul 2016 00:23:50 +0000 (17:23 -0700)
At the current point where ret is being checked for non-zero it has
not changed since it was initialized to zero, hence the check and the
label unref are redundant and can be removed.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
drivers/gpu/drm/vc4/vc4_drv.c

index 65f77cc243a695f0390b8d874d3e65ce9451aafc..2f30214ee8107b29f744a55b34b6588b172c189e 100644 (file)
@@ -198,8 +198,6 @@ static int vc4_drm_bind(struct device *dev)
        vc4_bo_cache_init(drm);
 
        drm_mode_config_init(drm);
-       if (ret)
-               goto unref;
 
        vc4_gem_init(drm);
 
@@ -233,7 +231,6 @@ unbind_all:
        component_unbind_all(dev, drm);
 gem_destroy:
        vc4_gem_destroy(drm);
-unref:
        drm_dev_unref(drm);
        vc4_bo_cache_destroy(drm);
        return ret;