projects / GitHub / LineageOS / android_kernel_samsung_universal7580.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 144dad9)
ALSA: cs46xx - signedness bug in snd_cs46xx_codec_read()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 10 Aug 2012 09:22:58 +0000 (12:22 +0300)
committerTakashi Iwai <tiwai@suse.de>
Fri, 10 Aug 2012 10:11:21 +0000 (12:11 +0200)
This function returns its own error codes instead of normal negative
error codes.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/cs46xx/cs46xx_lib.c patch | blob | blame | history

diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c
index f75f5ffdfdfb60724db8a90dbac5ca05447f3816..a71d1c14a0f6b9efa06bc91d2970bb304ebaa872 100644 (file)
--- a/sound/pci/cs46xx/cs46xx_lib.c
+++ b/sound/pci/cs46xx/cs46xx_lib.c
@@ -94,7 +94,7 @@ static unsigned short snd_cs46xx_codec_read(struct snd_cs46xx *chip,
 
        if (snd_BUG_ON(codec_index != CS46XX_PRIMARY_CODEC_INDEX &&
                       codec_index != CS46XX_SECONDARY_CODEC_INDEX))
-               return -EINVAL;
+               return 0xffff;
 
        chip->active_ctrl(chip, 1);