cgroup: make cgroup_subsys->base_cftypes use cgroup_add_cftypes()

Currently, cgroup_subsys->base_cftypes registration is different from
dynamic cftypes registartion.  Instead of going through
cgroup_add_cftypes(), cgroup_init_subsys() invokes
cgroup_init_cftsets() which makes use of cgroup_subsys->base_cftset
which doesn't involve dynamic allocation.

While avoiding dynamic allocation is somewhat nice, having two
separate paths for cftypes registration is nasty, especially as we're
planning to add more operations during cftypes registration.

This patch drops cgroup_init_cftsets() and cgroup_subsys->base_cftset
and registers base_cftypes using cgroup_add_cftypes().  This is done
as a separate step in cgroup_init() instead of a part of
cgroup_init_subsys().  This is because cgroup_init_subsys() can be
called very early during boot when kmalloc() isn't available yet.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 1ba4fc08f77645a803ea17bc9df07d854090e27b..c4350a82320b37ebc4853f4c686e4b8ea026632d 100644 (file)
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -604,9 +604,8 @@ struct cgroup_subsys {
        /* list of cftype_sets */
        struct list_head cftsets;
 
-       /* base cftypes, automatically [de]registered with subsys itself */
+       /* base cftypes, automatically registered with subsys itself */
        struct cftype *base_cftypes;
-       struct cftype_set base_cftset;
 };
 
 #define SUBSYS(_x) extern struct cgroup_subsys _x ## _cgrp_subsys;

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 3f204429d108cef4ac5040853d2df72b08d596bf..eb002c622cd6798e886d1f1e415ca401f85c2b6e 100644 (file)
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4503,25 +4503,6 @@ static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry)
        return ret;
 }
 
-static void __init cgroup_init_cftsets(struct cgroup_subsys *ss)
-{
-       INIT_LIST_HEAD(&ss->cftsets);
-
-       /*
-        * base_cftset is embedded in subsys itself, no need to worry about
-        * deregistration.
-        */
-       if (ss->base_cftypes) {
-               struct cftype *cft;
-
-               for (cft = ss->base_cftypes; cft->name[0] != '\0'; cft++)
-                       cft->ss = ss;
-
-               ss->base_cftset.cfts = ss->base_cftypes;
-               list_add_tail(&ss->base_cftset.node, &ss->cftsets);
-       }
-}
-
 static void __init cgroup_init_subsys(struct cgroup_subsys *ss)
 {
        struct cgroup_subsys_state *css;
@@ -4531,8 +4512,7 @@ static void __init cgroup_init_subsys(struct cgroup_subsys *ss)
        mutex_lock(&cgroup_tree_mutex);
        mutex_lock(&cgroup_mutex);
 
-       /* init base cftset */
-       cgroup_init_cftsets(ss);
+       INIT_LIST_HEAD(&ss->cftsets);
 
        /* Create the top cgroup state for this subsystem */
        ss->root = &cgroup_dummy_root;
@@ -4621,6 +4601,13 @@ int __init cgroup_init(void)
        for_each_subsys(ss, i) {
                if (!ss->early_init)
                        cgroup_init_subsys(ss);
+
+               /*
+                * cftype registration needs kmalloc and can't be done
+                * during early_init.  Register base cftypes separately.
+                */
+               if (ss->base_cftypes)
+                       WARN_ON(cgroup_add_cftypes(ss, ss->base_cftypes));
        }
 
        /* allocate id for the dummy hierarchy */