ll_temac: Use kcalloc instead of kzalloc to allocate array
authorThomas Meyer <thomas@m3y3r.de>
Fri, 2 Dec 2011 12:35:43 +0000 (12:35 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 4 Dec 2011 06:32:06 +0000 (01:32 -0500)
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xilinx/ll_temac_main.c

index 282330d9801bf7a5deb42f2835de5f1a77325703..903a77b416dfca59051b072bd06e9803287bc5b6 100644 (file)
@@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev)
        struct sk_buff *skb;
        int i;
 
-       lp->rx_skb = kzalloc(sizeof(*lp->rx_skb) * RX_BD_NUM, GFP_KERNEL);
+       lp->rx_skb = kcalloc(RX_BD_NUM, sizeof(*lp->rx_skb), GFP_KERNEL);
        if (!lp->rx_skb) {
                dev_err(&ndev->dev,
                                "can't allocate memory for DMA RX buffer\n");