drivers/net: remove exceptional & on function name
authorJulia Lawall <julia@diku.dk>
Wed, 18 Nov 2009 08:21:04 +0000 (08:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Nov 2009 18:48:38 +0000 (10:48 -0800)
In this file, function names are otherwise used as pointers without &.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier f;
@@

f(...) { ... }

@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethoc.c
drivers/net/pcmcia/fmvj18x_cs.c
drivers/net/pcmcia/nmclan_cs.c
drivers/net/tokenring/3c359.c
drivers/net/tokenring/olympic.c

index f1c565282d583ee4abaa9196bc6d91d3995f4d0c..96b6dc42fc740518541de09356b79db019303dfb 100644 (file)
@@ -640,7 +640,7 @@ static int ethoc_mdio_probe(struct net_device *dev)
                return -ENXIO;
        }
 
-       phy = phy_connect(dev, dev_name(&phy->dev), &ethoc_mdio_poll, 0,
+       phy = phy_connect(dev, dev_name(&phy->dev), ethoc_mdio_poll, 0,
                        PHY_INTERFACE_MODE_GMII);
        if (IS_ERR(phy)) {
                dev_err(&dev->dev, "could not attach to PHY\n");
index 7e01fbdb87e0f52ad94cb99d834c52dbd97aeaeb..57e09616330a7a178ea86a2c6de38e7be2d002df 100644 (file)
@@ -264,7 +264,7 @@ static int fmvj18x_probe(struct pcmcia_device *link)
     /* Interrupt setup */
     link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_HANDLE_PRESENT;
     link->irq.IRQInfo1 = IRQ_LEVEL_ID;
-    link->irq.Handler = &fjn_interrupt;
+    link->irq.Handler = fjn_interrupt;
     link->irq.Instance = dev;
 
     /* General socket configuration */
index 5ed6339c52bcbb6e021e08b334b6e614eacf75f8..b12e69592d18957ed32e60f2ddceaddd1d8a6316 100644 (file)
@@ -479,7 +479,7 @@ static int nmclan_probe(struct pcmcia_device *link)
     link->io.IOAddrLines = 5;
     link->irq.Attributes = IRQ_TYPE_EXCLUSIVE | IRQ_HANDLE_PRESENT;
     link->irq.IRQInfo1 = IRQ_LEVEL_ID;
-    link->irq.Handler = &mace_interrupt;
+    link->irq.Handler = mace_interrupt;
     link->irq.Instance = dev;
     link->conf.Attributes = CONF_ENABLE_IRQ;
     link->conf.IntType = INT_MEMORY_AND_IO;
index 724158966ec15ef7cf805536aa434ad1aaf1b124..cf552d1d9629be1cf0751dbf834b261663c276af 100644 (file)
@@ -610,9 +610,8 @@ static int xl_open(struct net_device *dev)
 
        u16 switchsettings, switchsettings_eeprom  ;
  
-       if(request_irq(dev->irq, &xl_interrupt, IRQF_SHARED , "3c359", dev)) {
+       if (request_irq(dev->irq, xl_interrupt, IRQF_SHARED , "3c359", dev))
                return -EAGAIN;
-       }
 
        /* 
         * Read the information from the EEPROM that we need.
index d9ec7f0bbd0af47dc9fa510cf37bddaa877364c8..df32025c513220ec15e11459cd53714c790e08f8 100644 (file)
@@ -445,9 +445,9 @@ static int olympic_open(struct net_device *dev)
 
        olympic_init(dev);
 
-       if(request_irq(dev->irq, &olympic_interrupt, IRQF_SHARED , "olympic", dev)) {
+       if (request_irq(dev->irq, olympic_interrupt, IRQF_SHARED , "olympic",
+                       dev))
                return -EAGAIN;
-       }
 
 #if OLYMPIC_DEBUG
        printk("BMCTL: %x\n",readl(olympic_mmio+BMCTL_SUM));