staging: hv: Remove NULL check before kfree
authorIlia Mirkin <imirkin@alum.mit.edu>
Sun, 13 Mar 2011 05:29:00 +0000 (00:29 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 14 Mar 2011 19:36:14 +0000 (12:36 -0700)
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Mike Sterling <mike.sterling@microsoft.com>
Cc: Abhishek Kane <v-abkane@microsoft.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/hv/channel_mgmt.c
drivers/staging/hv/connection.c
drivers/staging/hv/hv_mouse.c

index 33688094e1fdc016632a434b791fd9382643b577..bc0393a41d29bf8e230cebc073b72db6d2e7172e 100644 (file)
@@ -829,8 +829,7 @@ int vmbus_request_offers(void)
 
 
 cleanup:
-       if (msginfo)
-               kfree(msginfo);
+       kfree(msginfo);
 
        return ret;
 }
index fd589e381e31771d7b7c870b3341ae1507d9eff1..44b203b95a2290fe9f355e277a477222331eb8d0 100644 (file)
@@ -186,9 +186,7 @@ Cleanup:
                vmbus_connection.monitor_pages = NULL;
        }
 
-       if (msginfo) {
-               kfree(msginfo);
-       }
+       kfree(msginfo);
 
        return ret;
 }
index 8f94f433961f18e45699cfcfdb75dafea7813bd9..6fa462109ce973eea48968ba5c9b741c91160fc5 100644 (file)
@@ -402,15 +402,11 @@ static void MousevscOnReceiveDeviceInfo(struct mousevsc_dev *InputDevice, struct
        return;
 
 Cleanup:
-       if (InputDevice->HidDesc) {
-               kfree(InputDevice->HidDesc);
-               InputDevice->HidDesc = NULL;
-       }
+       kfree(InputDevice->HidDesc);
+       InputDevice->HidDesc = NULL;
 
-       if (InputDevice->ReportDesc) {
-               kfree(InputDevice->ReportDesc);
-               InputDevice->ReportDesc = NULL;
-       }
+       kfree(InputDevice->ReportDesc);
+       InputDevice->ReportDesc = NULL;
 
        InputDevice->DeviceInfoStatus = -1;
        InputDevice->device_wait_condition = 1;