[S390] cio: subchannels in no-path state.
authorPeter Oberparleiter <peter.oberparleiter@de.ibm.com>
Wed, 20 Sep 2006 13:59:54 +0000 (15:59 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Wed, 20 Sep 2006 13:59:54 +0000 (15:59 +0200)
Subchannel may incorrectly remain in state no-path after channel paths
have reappeared. Currently the scan for subchannels which are using a
channel path ends at the first occurrence if a full link address was
provided by the channel subsystem. The scan needs to continue over
all subchannels.

Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/cio/chsc.c

index c28444af0919f91df78cc5dde29d58ca87be05ee..9f9134b67e40c5ae0e923c54278a23bd3c30618f 100644 (file)
@@ -378,6 +378,7 @@ __s390_process_res_acc(struct subchannel_id schid, void *data)
 
        if (chp_mask == 0) {
                spin_unlock_irq(&sch->lock);
+               put_device(&sch->dev);
                return 0;
        }
        old_lpm = sch->lpm;
@@ -392,7 +393,7 @@ __s390_process_res_acc(struct subchannel_id schid, void *data)
 
        spin_unlock_irq(&sch->lock);
        put_device(&sch->dev);
-       return (res_data->fla_mask == 0xffff) ? -ENODEV : 0;
+       return 0;
 }