gpio: intel-mid: switch to devm_gpiochip_add_data()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Sun, 19 Jun 2016 20:49:57 +0000 (23:49 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 23 Jun 2016 09:07:13 +0000 (11:07 +0200)
The error handling is not correct since the commit 3f7dbfd8eea9 ("gpio:
intel-mid: switch to using gpiolib irqchip helpers"). Switch to devres API to
fix the potential resource leak.

Fixes: commit 3f7dbfd8eea9 ("gpio: intel-mid: switch to using gpiolib irqchip helpers")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-intel-mid.c

index cdaba13cb8e825a3355325f9f6fd5e1663a2bd1d..a99cf4b9395cb41b8a3185045130aeece3b3d92e 100644 (file)
@@ -401,7 +401,7 @@ static int intel_gpio_probe(struct pci_dev *pdev,
        spin_lock_init(&priv->lock);
 
        pci_set_drvdata(pdev, priv);
-       retval = gpiochip_add_data(&priv->chip, priv);
+       retval = devm_gpiochip_add_data(&pdev->dev, &priv->chip, priv);
        if (retval) {
                dev_err(&pdev->dev, "gpiochip_add error %d\n", retval);
                return retval;