switchdev: Fix return value of switchdev_port_fdb_dump().
authorRosen, Rami <rami.rosen@intel.com>
Fri, 2 Sep 2016 11:11:57 +0000 (14:11 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 2 Sep 2016 18:00:21 +0000 (11:00 -0700)
This patch fixes the retun value of switchdev_port_fdb_dump() when
CONFIG_NET_SWITCHDEV is not set. This avoids getting "warning: return makes
integer from pointer without a cast [-Wint-conversion]" when building
when CONFIG_NET_SWITCHDEV is not set under several compiler versions.
This warning is due to commit d297653dd6f07afbe7e6c702a4bcd7615680002e
("rtnetlink: fdb dump: optimize by saving last interface markers").

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/switchdev.h

index 6279f2f179ec8a4ade02449a8cb80239d042c5c4..729fe1534160a0905897629f7a23ee07e4d16a4c 100644 (file)
@@ -344,7 +344,7 @@ static inline int switchdev_port_fdb_dump(struct sk_buff *skb,
                                          struct net_device *filter_dev,
                                          int *idx)
 {
-       return idx;
+       return *idx;
 }
 
 static inline bool switchdev_port_same_parent_id(struct net_device *a,