mlx4_core: fix bug in modify_cq wrapper for resize flow.
authorJack Morgenstein <jackm@dev.mellanox.co.il>
Wed, 7 Mar 2012 05:56:35 +0000 (05:56 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Mar 2012 08:28:01 +0000 (00:28 -0800)
The actual FW command is called in procedure "handle_resize".
Code incorrectly invoked the FW command again (in good flow), in
the modify_cq wrapper function.

Fix by skipping second FW invocation unconditionally for resize.

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

index bfdb7af19e496285bdeff3ada8a302b71e746865..8752e6e0816922f5ecd4b441fc478b02a27fd5d2 100644 (file)
@@ -2255,8 +2255,7 @@ int mlx4_MODIFY_CQ_wrapper(struct mlx4_dev *dev, int slave,
 
        if (vhcr->op_modifier == 0) {
                err = handle_resize(dev, slave, vhcr, inbox, outbox, cmd, cq);
-               if (err)
-                       goto ex_put;
+               goto ex_put;
        }
 
        err = mlx4_DMA_wrapper(dev, slave, vhcr, inbox, outbox, cmd);