HID: logitech-dj: add HIDRAW dependency in Kconfig
authorOlivier Gay <ogay@logitech.com>
Mon, 2 Dec 2013 23:17:24 +0000 (00:17 +0100)
committerJiri Kosina <jkosina@suse.cz>
Tue, 3 Dec 2013 14:19:47 +0000 (15:19 +0100)
hid-logitech-dj.c driver needs hidraw to work correctly. Without
hidraw, hid-logitech-dj.c fails during probe() and Logitech
Unifying devices HID reports aren't recognized.

The unifying receiver has 3 usb interfaces. When hid-logitech-dj driver is
loaded, interfaces 0 and 1 are discarded.

Interface 2 consists of a hid class interface with 3 collections, each of
which sports the 'vendor' usage, thus, there is no reason for hid_input to
claim any of them. On the other hand, hidraw has no issue in claiming the
collections, even if they are 'vendor'. As of today, hid-logitech-dj uses
hidraw api to send configuration/control reports to interface 2 of the
Unifying receiver.

Without the hid-logitech-dj driver, interfaces 0 and 1 are claimed by
hid-input, as they correspond to a keyboard and a mouse. But that is not
relevant to the discussion.

[jkosina@suse.cz: make the changelog more verbose, thanks to Nestor]
Signed-off-by: Olivier Gay <ogay@logitech.com>
Signed-off-by: Nestor Lopez Casado <nlopezcasad@logitech.com>
Signed-off-by: Mathieu Meisser <mmeisser@logitech.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/Kconfig

index 329fbb9b59766f82af6c744e4e85a6ee1dc88208..c8a66b94b6ddcffd06229ed71e718fbcf8d2ab51 100644 (file)
@@ -344,6 +344,7 @@ config HID_LOGITECH
 
 config HID_LOGITECH_DJ
        tristate "Logitech Unifying receivers full support"
+       depends on HIDRAW
        depends on HID_LOGITECH
        ---help---
        Say Y if you want support for Logitech Unifying receivers and devices.