HID: hidp: Add a comment that some devices depend on the current behavior of uniq
authorFrank Praznik <frank.praznik@oh.rr.com>
Thu, 20 Feb 2014 16:36:04 +0000 (11:36 -0500)
committerJiri Kosina <jkosina@suse.cz>
Mon, 24 Feb 2014 16:38:46 +0000 (17:38 +0100)
Add a comment noting that some devices depend on the destination address being
stored in uniq.

Signed-off-by: Frank Praznik <frank.praznik@oh.rr.com>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
net/bluetooth/hidp/core.c

index 77c4badb3e9d7bbc93a1d1ff35fce210ce23a200..98e4840935e2bbe4e31cfd02506abb72e37ec03a 100644 (file)
@@ -767,6 +767,9 @@ static int hidp_setup_hid(struct hidp_session *session,
        snprintf(hid->phys, sizeof(hid->phys), "%pMR",
                 &l2cap_pi(session->ctrl_sock->sk)->chan->src);
 
+       /* NOTE: Some device modules depend on the dst address being stored in
+        * uniq. Please be aware of this before making changes to this behavior.
+        */
        snprintf(hid->uniq, sizeof(hid->uniq), "%pMR",
                 &l2cap_pi(session->ctrl_sock->sk)->chan->dst);