drm/i915: Don't return error on sink crc stop.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 23 Jul 2015 23:35:46 +0000 (16:35 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 29 Jul 2015 08:23:56 +0000 (10:23 +0200)
If we got to the point where we are trying to stop sink CRC
the main output of this function was already gotten properly,
so don't return the error and let userspace use the crc data.

Let's replace the errnos returns with some log messages.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_dp.c

index 70a4a37b7f7fc612362cd7a0db670ec6b754dd6d..44f8a32e4d1e0d00c5dede4bde863d7b88793a5a 100644 (file)
@@ -4021,12 +4021,12 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
 
 stop:
        if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK, &buf) < 0) {
-               ret = -EIO;
+               DRM_DEBUG_KMS("Sink CRC couldn't be stopped properly\n");
                goto out;
        }
        if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK,
                               buf & ~DP_TEST_SINK_START) < 0) {
-               ret = -EIO;
+               DRM_DEBUG_KMS("Sink CRC couldn't be stopped properly\n");
                goto out;
        }
 out: