ASoC: rockchip: Remove unnecessary function call
authorDonglin Peng <dolinux.peng@gmail.com>
Sun, 20 Aug 2017 05:25:46 +0000 (13:25 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 21 Aug 2017 16:13:20 +0000 (17:13 +0100)
First of all,the address of pdev->dev is assigned to card->dev,then
the function platform_set_drvdata copies the value the variable card
to pdev->dev.driver_data, but when calling snd_soc_register_card,the
function dev_set_drvdata(card->dev, card) will also do the same copy
operation,so i think that the former copy operation can be removed.

Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rk3288_hdmi_analog.c
sound/soc/rockchip/rk3399_gru_sound.c

index 42227b0f66acaa63b5bc5ba8039724ad09312e26..fa44e3901336d97342a1e158a2c1c066f9d0bc41 100644 (file)
@@ -272,8 +272,6 @@ static int snd_rk_mc_probe(struct platform_device *pdev)
                return ret;
        }
 
-       platform_set_drvdata(pdev, card);
-
        return ret;
 }
 
index 3475c61a5fa0bf76f989bd21bf43815b75aef627..70c0908fb9b4ca0e4c43d4bf0625cf2fe97764ae 100644 (file)
@@ -362,7 +362,6 @@ static int rockchip_sound_probe(struct platform_device *pdev)
        rockchip_dailinks[DAILINK_RT5514_DSP].platform_name = kstrdup_const(dev_name(dev), GFP_KERNEL);
 
        card->dev = &pdev->dev;
-       platform_set_drvdata(pdev, card);
 
        ret = devm_snd_soc_register_card(&pdev->dev, card);
        if (ret)