tty: handle NULL parameters in free_tty_struct()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 24 Jul 2012 11:52:04 +0000 (12:52 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Aug 2012 19:54:27 +0000 (12:54 -0700)
We sometimes pass NULL pointers to free_tty_struct().  One example where
it can happen is in the error handling code in pty_common_install().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_io.c

index 608749978df41883b7f00669585dc78f341b86ea..6784aae210e355cce131f959056b5a5c1163380a 100644 (file)
@@ -181,6 +181,8 @@ struct tty_struct *alloc_tty_struct(void)
 
 void free_tty_struct(struct tty_struct *tty)
 {
+       if (!tty)
+               return;
        if (tty->dev)
                put_device(tty->dev);
        kfree(tty->write_buf);