nvme-fc: fix a missing queue put in nvmet_fc_ls_create_association
authorAmit Engel <Amit.Engel@dell.com>
Mon, 23 Jan 2023 12:37:28 +0000 (14:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:46:05 +0000 (12:46 +0100)
[ Upstream commit 0cab4404874f2de52617de8400c844891c6ea1ce ]

As part of nvmet_fc_ls_create_association there is a case where
nvmet_fc_alloc_target_queue fails right after a new association with an
admin queue is created. In this case, no one releases the get taken in
nvmet_fc_alloc_target_assoc.  This fix is adding the missing put.

Signed-off-by: Amit Engel <Amit.Engel@dell.com>
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/target/fc.c

index df1c6dee255bfae5810ef2c92c188439fd474d22..b702bdc589551fac2c59dbc0b2b678b7fc687b4b 100644 (file)
@@ -1301,8 +1301,10 @@ nvmet_fc_ls_create_association(struct nvmet_fc_tgtport *tgtport,
                else {
                        queue = nvmet_fc_alloc_target_queue(iod->assoc, 0,
                                        be16_to_cpu(rqst->assoc_cmd.sqsize));
-                       if (!queue)
+                       if (!queue) {
                                ret = VERR_QUEUE_ALLOC_FAIL;
+                               nvmet_fc_tgt_a_put(iod->assoc);
+                       }
                }
        }