projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 74c9c0f)
[media] adv7511: fix incorrect bit offset
authorHans Verkuil <hansverk@cisco.com>
Thu, 12 Nov 2015 15:30:39 +0000 (13:30 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 17 Nov 2015 16:39:54 +0000 (14:39 -0200)
The quantization bits are in bits 7-6, not 7-4, so shift by 6 instead of 4.

This bug is caused by a typo in the adv7511 datasheet.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/adv7511.c patch | blob | blame | history

diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c
index d24c9ebc740e9192b275ddd587b0e4f5941f06e2..eeb2cd823c4d1fe0d40aa7c5e57c08bab3f56cec 100644 (file)
--- a/drivers/media/i2c/adv7511.c
+++ b/drivers/media/i2c/adv7511.c
@@ -1116,7 +1116,7 @@ static int adv7511_set_fmt(struct v4l2_subdev *sd,
        adv7511_wr_and_or(sd, 0x55, 0x9f, y << 5);
        adv7511_wr_and_or(sd, 0x56, 0x3f, c << 6);
        adv7511_wr_and_or(sd, 0x57, 0x83, (ec << 4) | (q << 2));
-       adv7511_wr_and_or(sd, 0x59, 0x0f, yq << 4);
+       adv7511_wr_and_or(sd, 0x59, 0x3f, yq << 6);
        adv7511_wr_and_or(sd, 0x4a, 0xff, 1);
 
        return 0;