[PATCH] sky2: don't bother clearing status ring elements
authorStephen Hemminger <shemminger@osdl.org>
Tue, 17 Jan 2006 21:43:15 +0000 (13:43 -0800)
committerJeff Garzik <jgarzik@pobox.com>
Wed, 18 Jan 2006 00:27:29 +0000 (19:27 -0500)
Don't need to zero out the status ring entries after processing.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/net/sky2.c

index 1407ff2da41e060e618070a98f517b58bc17bc20..3c5d00403e5e073a1cca2d285c7bd0826c9205d4 100644 (file)
@@ -1825,7 +1825,6 @@ static int sky2_poll(struct net_device *dev0, int *budget)
                struct sk_buff *skb;
                u32 status;
                u16 length;
-               u8 op;
 
                le = hw->st_le + hw->st_idx;
                hw->st_idx = (hw->st_idx + 1) % STATUS_RING_SIZE;
@@ -1839,10 +1838,8 @@ static int sky2_poll(struct net_device *dev0, int *budget)
                sky2 = netdev_priv(dev);
                status = le32_to_cpu(le->status);
                length = le16_to_cpu(le->length);
-               op = le->opcode & ~HW_OWNER;
-               le->opcode = 0;
 
-               switch (op) {
+               switch (le->opcode & ~HW_OWNER) {
                case OP_RXSTAT:
                        skb = sky2_receive(sky2, length, status);
                        if (!skb)
@@ -1890,7 +1887,7 @@ static int sky2_poll(struct net_device *dev0, int *budget)
                default:
                        if (net_ratelimit())
                                printk(KERN_WARNING PFX
-                                      "unknown status opcode 0x%x\n", op);
+                                      "unknown status opcode 0x%x\n", le->opcode);
                        break;
                }
        }