carl9170: interrupt urbs must not set URB_ZERO_PACKET
authorChristian Lamparter <chunkeey@googlemail.com>
Mon, 27 Sep 2010 23:53:42 +0000 (01:53 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 28 Sep 2010 19:47:58 +0000 (15:47 -0400)
This patch fixes a bug in the driver which was
exposed by CONFIG_USB_DEBUG:
"usb 1-1.6.3: BOGUS urb flags, 40 --> 0"

The transfer flag "URB_ZERO_PACKET" is only valid
for bulk urbs.

Reported-by: André Erdmann
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/carl9170/usb.c

index eb789a9e4f15d7287e11ec4ccb29bb7e52f1bf06..c7f6193934eaabe82cbe8cb5acdbd23afda48662 100644 (file)
@@ -606,8 +606,6 @@ int __carl9170_exec_cmd(struct ar9170 *ar, struct carl9170_cmd *cmd,
                AR9170_USB_EP_CMD), cmd, cmd->hdr.len + 4,
                carl9170_usb_cmd_complete, ar, 1);
 
-       urb->transfer_flags |= URB_ZERO_PACKET;
-
        if (free_buf)
                urb->transfer_flags |= URB_FREE_BUFFER;