serial: rate limit custom-speed deprecation notice
authorJohan Hovold <johan@kernel.org>
Tue, 6 Jun 2017 10:54:33 +0000 (12:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Jun 2017 09:49:57 +0000 (11:49 +0200)
Contrary to what a comment claimed, the ASYNC_SPD flags and custom
divisor can be set by a non-privileged user so rate limit the
deprecation notice as was intended.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/serial_core.c

index 13bfd5dcffce5c0bfaee47879277e32aedf308a9..f534a40aebdeeadba3f344f229f1b8ac067370d1 100644 (file)
@@ -954,11 +954,10 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
                    old_custom_divisor != uport->custom_divisor) {
                        /*
                         * If they're setting up a custom divisor or speed,
-                        * instead of clearing it, then bitch about it. No
-                        * need to rate-limit; it's CAP_SYS_ADMIN only.
+                        * instead of clearing it, then bitch about it.
                         */
                        if (uport->flags & UPF_SPD_MASK) {
-                               dev_notice(uport->dev,
+                               dev_notice_ratelimited(uport->dev,
                                       "%s sets custom speed on %s. This is deprecated.\n",
                                      current->comm,
                                      tty_name(port->tty));