Fix condition in `Dependency/Manager.isHiddenByDependencies()`

The checked node is considered hidden, if it (`node`) is in a hidden node (`hiddenNode`) .
The variables were mixed up in this condition during the transition to TypeScript.

diff --git a/ts/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.ts b/ts/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.ts
index 7effcac1c3a0d924911d88b0e6204d58ff798d3e..e005d02ec66a011ee294374dc8a1aa979fe1899e 100644 (file)
--- a/ts/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.ts
+++ b/ts/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.ts
@@ -235,7 +235,7 @@ export function isHiddenByDependencies(node: HTMLElement): boolean {
 
   let returnValue = false;
   _dependencyHiddenNodes.forEach((hiddenNode) => {
-    if (node.contains(hiddenNode)) {
+    if (hiddenNode.contains(node)) {
       returnValue = true;
     }
   });

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js
index 66057c8e29848e35af3759b61877d226115fbd91..0e3502e1d77d7bbd801b3b3bfbb2a9cbd857423e 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Form/Builder/Field/Dependency/Manager.js
@@ -201,7 +201,7 @@ define(["require", "exports", "tslib", "../../../../Dom/Util", "../../../../Even
         }
         let returnValue = false;
         _dependencyHiddenNodes.forEach((hiddenNode) => {
-            if (node.contains(hiddenNode)) {
+            if (hiddenNode.contains(node)) {
                 returnValue = true;
             }
         });