s390/zcrypt: Add some debug messages on failure.
authorHarald Freudenberger <freude@linux.vnet.ibm.com>
Fri, 12 May 2017 16:53:41 +0000 (18:53 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Mon, 12 Jun 2017 14:25:59 +0000 (16:25 +0200)
Added some dbf debug messages on failure of the most important
ioctl calls. These messages are only enabled with dbf level
6 (debug) and so do not affect the normal operating mode which
uses level 3 (errors and higher).

Signed-off-by: Harald Freudenberger <freude@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/crypto/zcrypt_api.c

index 93015f85d4a6a9c17ff4daae5d4bcdebb774057c..b1c27e28859bdbeaa1bc14110da0315287ff7815 100644 (file)
@@ -821,8 +821,10 @@ static long zcrypt_unlocked_ioctl(struct file *filp, unsigned int cmd,
                        do {
                                rc = zcrypt_rsa_modexpo(&mex);
                        } while (rc == -EAGAIN);
-               if (rc)
+               if (rc) {
+                       ZCRYPT_DBF(DBF_DEBUG, "ioctl ICARSAMODEXPO rc=%d", rc);
                        return rc;
+               }
                return put_user(mex.outputdatalength, &umex->outputdatalength);
        }
        case ICARSACRT: {
@@ -838,8 +840,10 @@ static long zcrypt_unlocked_ioctl(struct file *filp, unsigned int cmd,
                        do {
                                rc = zcrypt_rsa_crt(&crt);
                        } while (rc == -EAGAIN);
-               if (rc)
+               if (rc) {
+                       ZCRYPT_DBF(DBF_DEBUG, "ioctl ICARSACRT rc=%d", rc);
                        return rc;
+               }
                return put_user(crt.outputdatalength, &ucrt->outputdatalength);
        }
        case ZSECSENDCPRB: {
@@ -855,6 +859,8 @@ static long zcrypt_unlocked_ioctl(struct file *filp, unsigned int cmd,
                        do {
                                rc = zcrypt_send_cprb(&xcRB);
                        } while (rc == -EAGAIN);
+               if (rc)
+                       ZCRYPT_DBF(DBF_DEBUG, "ioctl ZSENDCPRB rc=%d", rc);
                if (copy_to_user(uxcRB, &xcRB, sizeof(xcRB)))
                        return -EFAULT;
                return rc;
@@ -872,6 +878,8 @@ static long zcrypt_unlocked_ioctl(struct file *filp, unsigned int cmd,
                        do {
                                rc = zcrypt_send_ep11_cprb(&xcrb);
                        } while (rc == -EAGAIN);
+               if (rc)
+                       ZCRYPT_DBF(DBF_DEBUG, "ioctl ZSENDEP11CPRB rc=%d", rc);
                if (copy_to_user(uxcrb, &xcrb, sizeof(xcrb)))
                        return -EFAULT;
                return rc;