ASoC: soc-core: skip zero num_dai component in searching dai name
authorShengjiu Wang <shengjiu.wang@nxp.com>
Thu, 10 Feb 2022 11:19:12 +0000 (19:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:06:39 +0000 (09:06 +0200)
[ Upstream commit f7d344a2bd5ec81fbd1ce76928fd059e57ec9bea ]

In the case like dmaengine which's not a dai but as a component, the
num_dai is zero, dmaengine component has the same component_of_node
as cpu dai, when cpu dai component is not ready, but dmaengine component
is ready, try to get cpu dai name, the snd_soc_get_dai_name() return
-EINVAL, not -EPROBE_DEFER, that cause below error:

asoc-simple-card <card name>: parse error -22
asoc-simple-card: probe of <card name> failed with error -22

The sound card failed to probe.

So this patch fixes the issue above by skipping the zero num_dai
component in searching dai name.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Link: https://lore.kernel.org/r/1644491952-7457-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/soc-core.c

index 0344d44231675f44f4817c4405973f9b0d7f517f..81c3aa167038220204e38970971d17ad69e32e10 100644 (file)
@@ -3799,7 +3799,7 @@ static int snd_soc_get_dai_name(struct of_phandle_args *args,
                if (!component_of_node && pos->dev->parent)
                        component_of_node = pos->dev->parent->of_node;
 
-               if (component_of_node != args->np)
+               if (component_of_node != args->np || !pos->num_dai)
                        continue;
 
                if (pos->driver->of_xlate_dai_name) {