IB/hfi1: Coding style improvement (make sizeof use safer)
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 10 Feb 2017 20:45:38 +0000 (21:45 +0100)
committerDoug Ledford <dledford@redhat.com>
Thu, 20 Apr 2017 20:25:04 +0000 (16:25 -0400)
Replace the specification of a data structure by a reference to
the desired member as the parameter for the operator "sizeof" to make
the corresponding size determination a bit safer according to
the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/hw/hfi1/user_sdma.c

index 252f0c183d61e530ca4cc77bd969ff0f5b466080..0749689d76439f7ac95efdfceb04c5299bd80f26 100644 (file)
@@ -705,7 +705,9 @@ int hfi1_user_sdma_process_request(struct file *fp, struct iovec *iovec,
        /* Save all the IO vector structures */
        for (i = 0; i < req->data_iovs; i++) {
                INIT_LIST_HEAD(&req->iovs[i].list);
-               memcpy(&req->iovs[i].iov, iovec + idx++, sizeof(struct iovec));
+               memcpy(&req->iovs[i].iov,
+                      iovec + idx++,
+                      sizeof(req->iovs[i].iov));
                ret = pin_vector_pages(req, &req->iovs[i]);
                if (ret) {
                        req->status = ret;