watchdog: pic32-wdt: Fix return value check in pic32_wdt_drv_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 17 Jun 2016 17:11:35 +0000 (17:11 +0000)
committerWim Van Sebroeck <wim@iguana.be>
Sun, 17 Jul 2016 19:01:43 +0000 (21:01 +0200)
In case of error, the function devm_kzalloc() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/pic32-wdt.c

index 6047aa89a4d36f823035f9b2054a15c5723b8a1b..2b7a2b22fcb2336c0ea9e4da14bb7a47b17299c4 100644 (file)
@@ -174,8 +174,8 @@ static int pic32_wdt_drv_probe(struct platform_device *pdev)
        struct resource *mem;
 
        wdt = devm_kzalloc(&pdev->dev, sizeof(*wdt), GFP_KERNEL);
-       if (IS_ERR(wdt))
-               return PTR_ERR(wdt);
+       if (!wdt)
+               return -ENOMEM;
 
        mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        wdt->regs = devm_ioremap_resource(&pdev->dev, mem);