ath5k: fix hw rate index condition
authorJiri Slaby <jirislaby@gmail.com>
Thu, 26 Feb 2009 22:44:31 +0000 (23:44 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 5 Mar 2009 19:39:32 +0000 (14:39 -0500)
Make sure we print out a warning when the index is out of bounds,
i.e. even on hw_rix == AR5K_MAX_RATES.

Also change to WARN and print text with the reported hw_rix.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis R. Rodriguez <lrodriguez@atheros.com>
Cc: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath5k/base.c

index bce825b9ff1b665e7286d9e4353c0447d207bf12..f7c424dcac66a5dc8719b80932bb928af1a1ba00 100644 (file)
@@ -1100,7 +1100,8 @@ ath5k_mode_setup(struct ath5k_softc *sc)
 static inline int
 ath5k_hw_to_driver_rix(struct ath5k_softc *sc, int hw_rix)
 {
-       WARN_ON(hw_rix < 0 || hw_rix > AR5K_MAX_RATES);
+       WARN(hw_rix < 0 || hw_rix >= AR5K_MAX_RATES,
+                       "hw_rix out of bounds: %x\n", hw_rix);
        return sc->rate_idx[sc->curband->band][hw_rix];
 }