i40e: fix incorrect variable assignment
authorGustavo A R Silva <garsilva@embeddedor.com>
Thu, 15 Jun 2017 02:38:26 +0000 (21:38 -0500)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 26 Jul 2017 10:25:18 +0000 (03:25 -0700)
Fix incorrect variable assignment.
Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be
used in this instance is aq_ret instead of ret. Also, variable ret is
updated at line 1602 just before return, so assigning a value to this
variable in this code block is useless.

Addresses-Coverity-ID: 1397693
Signed-off-by: Gustavo A R Silva <garsilva@embeddedor.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

index ecbe40ea8ffeffcab397370c7f52da16b14a917c..ba327e90f32adeb5ac882278b62b49c09bbe2442 100644 (file)
@@ -1567,7 +1567,7 @@ static int i40e_vc_get_vf_resources_msg(struct i40e_vf *vf, u8 *msg)
                        dev_err(&pf->pdev->dev,
                                "VF %d requested polling mode: this feature is supported only when the device is running in single function per port (SFP) mode\n",
                                 vf->vf_id);
-                       ret = I40E_ERR_PARAM;
+                       aq_ret = I40E_ERR_PARAM;
                        goto err;
                }
                vfres->vf_offload_flags |= VIRTCHNL_VF_OFFLOAD_RX_POLLING;