bnx2x: pfc statistics counts pfc events twice
authorYuval Mintz <yuvalmin@broadcom.com>
Mon, 12 Mar 2012 11:22:04 +0000 (11:22 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 13 Mar 2012 00:01:25 +0000 (17:01 -0700)
When pfc statistics were counted, the delta change from last count
was summed twice. This fixes the issue.

Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.c

index 1adef266fcd50252deb5f8684d6708656a577765..a766b25eec5fd20130efb99a545543e006286998 100644 (file)
@@ -554,23 +554,11 @@ static void bnx2x_bmac_stats_update(struct bnx2x *bp)
                UPDATE_STAT64(tx_stat_gtufl, tx_stat_mac_ufl);
 
                /* collect PFC stats */
-               DIFF_64(diff.hi, new->tx_stat_gtpp_hi,
-                       pstats->pfc_frames_tx_hi,
-                       diff.lo, new->tx_stat_gtpp_lo,
-                       pstats->pfc_frames_tx_lo);
                pstats->pfc_frames_tx_hi = new->tx_stat_gtpp_hi;
                pstats->pfc_frames_tx_lo = new->tx_stat_gtpp_lo;
-               ADD_64(pstats->pfc_frames_tx_hi, diff.hi,
-                       pstats->pfc_frames_tx_lo, diff.lo);
 
-               DIFF_64(diff.hi, new->rx_stat_grpp_hi,
-                       pstats->pfc_frames_rx_hi,
-                       diff.lo, new->rx_stat_grpp_lo,
-                       pstats->pfc_frames_rx_lo);
                pstats->pfc_frames_rx_hi = new->rx_stat_grpp_hi;
                pstats->pfc_frames_rx_lo = new->rx_stat_grpp_lo;
-               ADD_64(pstats->pfc_frames_rx_hi, diff.hi,
-                       pstats->pfc_frames_rx_lo, diff.lo);
        }
 
        estats->pause_frames_received_hi =