vme: fake: remove unexpected unlock in fake_master_set()

image->lock is unlocked in some error handling path without take the
lock, so remove those unexpected unlock.

Fixes: 658bcdae9c67 ("vme: Adding Fake VME driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/vme/bridges/vme_fake.c b/drivers/vme/bridges/vme_fake.c
index 29ac74f7889d1ec05d3edbfca5b48cdedd808914..30b3acc9383309509862e0d1b942c22bc82a5361 100644 (file)
--- a/drivers/vme/bridges/vme_fake.c
+++ b/drivers/vme/bridges/vme_fake.c
@@ -273,7 +273,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
        }
 
        if (size & 0xFFFF) {
-               spin_unlock(&image->lock);
                pr_err("Invalid size alignment\n");
                retval = -EINVAL;
                goto err_window;
@@ -292,7 +291,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
        case VME_D32:
                break;
        default:
-               spin_unlock(&image->lock);
                pr_err("Invalid data width\n");
                retval = -EINVAL;
                goto err_dwidth;
@@ -311,7 +309,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
        case VME_USER4:
                break;
        default:
-               spin_unlock(&image->lock);
                pr_err("Invalid address space\n");
                retval = -EINVAL;
                goto err_aspace;