mm/rmap.c: cleanup ttu_flags

Transform action part of ttu_flags into individiual bits.  These flags
aren't part of any uses-space visible api or even trace events.

Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Rik van Riel <riel@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/include/linux/rmap.h b/include/linux/rmap.h
index 9be55c7617da563580cc7f1cadc03eaebc6349b8..be574506e6a93074983f73b9ba62c07a50b4deeb 100644 (file)
--- a/include/linux/rmap.h
+++ b/include/linux/rmap.h
@@ -72,10 +72,9 @@ struct anon_vma_chain {
 };
 
 enum ttu_flags {
-       TTU_UNMAP = 0,                  /* unmap mode */
-       TTU_MIGRATION = 1,              /* migration mode */
-       TTU_MUNLOCK = 2,                /* munlock mode */
-       TTU_ACTION_MASK = 0xff,
+       TTU_UNMAP = 1,                  /* unmap mode */
+       TTU_MIGRATION = 2,              /* migration mode */
+       TTU_MUNLOCK = 4,                /* munlock mode */
 
        TTU_IGNORE_MLOCK = (1 << 8),    /* ignore mlock */
        TTU_IGNORE_ACCESS = (1 << 9),   /* don't age */

diff --git a/mm/rmap.c b/mm/rmap.c
index ab74290d185d58b2579a0c2a01e44e3408d91261..ea8e20d75b29cb45e8293ed8ab1c5214bfd4358b 100644 (file)
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -1162,7 +1162,7 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
                if (vma->vm_flags & VM_LOCKED)
                        goto out_mlock;
 
-               if (TTU_ACTION(flags) == TTU_MUNLOCK)
+               if (flags & TTU_MUNLOCK)
                        goto out_unmap;
        }
        if (!(flags & TTU_IGNORE_ACCESS)) {
@@ -1230,7 +1230,7 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
                         * pte. do_swap_page() will wait until the migration
                         * pte is removed and then restart fault handling.
                         */
-                       BUG_ON(TTU_ACTION(flags) != TTU_MIGRATION);
+                       BUG_ON(!(flags & TTU_MIGRATION));
                        entry = make_migration_entry(page, pte_write(pteval));
                }
                swp_pte = swp_entry_to_pte(entry);
@@ -1239,7 +1239,7 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
                set_pte_at(mm, address, pte, swp_pte);
                BUG_ON(pte_file(*pte));
        } else if (IS_ENABLED(CONFIG_MIGRATION) &&
-                  (TTU_ACTION(flags) == TTU_MIGRATION)) {
+                  (flags & TTU_MIGRATION)) {
                /* Establish migration entry for a file page */
                swp_entry_t entry;
                entry = make_migration_entry(page, pte_write(pteval));
@@ -1252,7 +1252,7 @@ static int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
 
 out_unmap:
        pte_unmap_unlock(pte, ptl);
-       if (ret != SWAP_FAIL && TTU_ACTION(flags) != TTU_MUNLOCK)
+       if (ret != SWAP_FAIL && !(flags & TTU_MUNLOCK))
                mmu_notifier_invalidate_page(mm, address);
 out:
        return ret;
@@ -1539,7 +1539,7 @@ int try_to_unmap(struct page *page, enum ttu_flags flags)
         * locking requirements of exec(), migration skips
         * temporary VMAs until after exec() completes.
         */
-       if (flags & TTU_MIGRATION && !PageKsm(page) && PageAnon(page))
+       if ((flags & TTU_MIGRATION) && !PageKsm(page) && PageAnon(page))
                rwc.invalid_vma = invalid_migration_vma;
 
        ret = rmap_walk(page, &rwc);