mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers

The ChromeOS EC SPI and I2C transport drivers depends on CROS_EC_PROTO
but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
on is bad practice as it may lead to circular Kconfig dependencies.

Since these drivers already depend on MFD_CROS_EC and that config option
already selects CROS_EC_PROTO, there is no need to make them explicitly
depend on CROS_EC_PROTO since that dependency is already met.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 93837b4e8025010d15c1395e4dd98a7033df4723..dd55c25fb656a3f80ed005264bc205d9f67128bc 100644 (file)
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -105,7 +105,7 @@ config MFD_CROS_EC
 
 config MFD_CROS_EC_I2C
        tristate "ChromeOS Embedded Controller (I2C)"
-       depends on MFD_CROS_EC && CROS_EC_PROTO && I2C
+       depends on MFD_CROS_EC && I2C
 
        help
          If you say Y here, you get support for talking to the ChromeOS
@@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C
 
 config MFD_CROS_EC_SPI
        tristate "ChromeOS Embedded Controller (SPI)"
-       depends on MFD_CROS_EC && CROS_EC_PROTO && SPI
+       depends on MFD_CROS_EC && SPI
 
        ---help---
          If you say Y here, you get support for talking to the ChromeOS EC