pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked

And remove superfluous brackets.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index bcec05b5c67eb8f3903af4601ef6f84153bb4d8d..986d0e02761c81ca3a85e4ddbb11bcd38e7304b2 100644 (file)
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -956,9 +956,8 @@ static int pinctrl_select_state_locked(struct pinctrl *p,
                        break;
                }
 
-               if (ret < 0) {
+               if (ret < 0)
                        goto unapply_new_state;
-               }
        }
 
        p->state = state;
@@ -966,7 +965,7 @@ static int pinctrl_select_state_locked(struct pinctrl *p,
        return 0;
 
 unapply_new_state:
-       pr_info("Error applying setting, reverse things back\n");
+       dev_err(p->dev, "Error applying setting, reverse things back\n");
 
        /*
         * If the loop stopped on the 1st entry, nothing has been enabled,