link_path_walk: nd->depth massage, part 3
authorAl Viro <viro@zeniv.linux.org.uk>
Mon, 4 May 2015 00:52:15 +0000 (20:52 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 11 May 2015 02:20:03 +0000 (22:20 -0400)
remove decrement/increment surrounding nd_alloc_stack(), adjust the
test in it.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namei.c

index a4034255d8274c482fca4e7a4b7f2952369253b9..3df4731a746790c5d0f7919f9702a14660e85e79 100644 (file)
@@ -539,7 +539,7 @@ static int __nd_alloc_stack(struct nameidata *nd)
 
 static inline int nd_alloc_stack(struct nameidata *nd)
 {
-       if (likely(nd->depth != EMBEDDED_LEVELS - 1))
+       if (likely(nd->depth != EMBEDDED_LEVELS))
                return 0;
        if (likely(nd->stack != nd->internal))
                return 0;
@@ -1824,9 +1824,7 @@ Walked:
                if (err) {
                        const char *s;
 
-                       nd->depth--;
                        err = nd_alloc_stack(nd);
-                       nd->depth++;
                        if (unlikely(err)) {
                                path_to_nameidata(&nd->link, nd);
                                break;