drm/amd/powerplay: refine the dmesg info.
authorRex Zhu <Rex.Zhu@amd.com>
Thu, 21 Jan 2016 11:33:56 +0000 (19:33 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 5 Mar 2016 17:33:40 +0000 (12:33 -0500)
this do not mean driver error.

Change-Id: If2080eb4b79fc6389280b7c75cb7998d77090739
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c

index ef1daf1251c7e8e610de201bf183e2cd022ad61f..7fdaf8c3f7a9db1f00c8e4712ea7c4d7ce4f6359 100644 (file)
@@ -726,8 +726,9 @@ static int cz_tf_update_sclk_limit(struct pp_hwmgr *hwmgr,
                cz_hwmgr->sclk_dpm.soft_max_clk  = table->entries[table->count - 1].clk;
 
        clock = hwmgr->display_config.min_core_set_clock;
+;
        if (clock == 0)
-               printk(KERN_ERR "[ powerplay ] min_core_set_clock not set\n");
+               printk(KERN_INFO "[ powerplay ] min_core_set_clock not set\n");
 
        if (cz_hwmgr->sclk_dpm.hard_min_clk != clock) {
                cz_hwmgr->sclk_dpm.hard_min_clk = clock;
index 9deadabbc81c62acabf34faafcf3690f4334c244..72cfecc4f9f729426e602ce6a09db56f10eb8527 100644 (file)
@@ -34,6 +34,11 @@ static int phm_run_table(struct pp_hwmgr *hwmgr,
        int result = 0;
        phm_table_function *function;
 
+       if (rt_table->function_list == NULL) {
+               printk(KERN_INFO "[ powerplay ] this function not implement!\n");
+               return 0;
+       }
+
        for (function = rt_table->function_list; NULL != *function; function++) {
                int tmp = (*function)(hwmgr, input, output, temp_storage, result);
 
@@ -57,9 +62,9 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr,
        int result = 0;
        void *temp_storage = NULL;
 
-       if (hwmgr == NULL || rt_table == NULL || rt_table->function_list == NULL) {
+       if (hwmgr == NULL || rt_table == NULL) {
                printk(KERN_ERR "[ powerplay ] Invalid Parameter!\n");
-               return 0; /*temp return ture because some function not implement on some asic */
+               return -EINVAL;
        }
 
        if (0 != rt_table->storage_size) {