net/macb: add comment in macb_probe_queues
authorNicolas Ferre <nicolas.ferre@atmel.com>
Tue, 31 Mar 2015 13:02:00 +0000 (15:02 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 31 Mar 2015 20:51:17 +0000 (16:51 -0400)
As we access the MID register directly, we need to tell why
we don't use the macb_is_gem() dedicated function.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb.c

index ac1f18142f7e603f761ec0bffa1482a5f6bd76d8..68d59b3900b1a2b5038332f828f69251990dd332 100644 (file)
@@ -2161,9 +2161,13 @@ static void macb_probe_queues(void __iomem *mem,
        *queue_mask = 0x1;
        *num_queues = 1;
 
-       /* is it macb or gem ? */
+       /* is it macb or gem ?
+        *
+        * We need to read directly from the hardware here because
+        * we are early in the probe process and don't have the
+        * MACB_CAPS_MACB_IS_GEM flag positioned
+        */
        mid = readl_relaxed(mem + MACB_MID);
-
        if (MACB_BFEXT(IDNUM, mid) < 0x2)
                return;