rtlwifi: make a couple arrays larger
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 18 Aug 2017 08:05:19 +0000 (11:05 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 24 Aug 2017 09:53:50 +0000 (12:53 +0300)
This is a static checker fix.  "cal_num" is 10.  We're declaring the
tx_dt[] and rx_td[] arrays as 3 element arrays.  The static checker
complains that we do:

tx_dt[cal] = (vdf_y[1]>>20)-(vdf_y[0]>>20);

"cal" is the iterator and it is in the 0-9 range so it looks like
we could corrupt memory.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c

index aa3ccc740521d07755c387760f476ae71d27f7c0..176deb2b5386823dc7f3ce7c85cfe4d79c3bbe5e 100644 (file)
@@ -3773,10 +3773,11 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path)
        u32     tx_fail, rx_fail, delay_count, iqk_ready, cal_retry, cal = 0, temp_reg65;
        int     tx_x = 0, tx_y = 0, rx_x = 0, rx_y = 0, tx_average = 0, rx_average = 0;
        int     tx_x0[cal_num], tx_y0[cal_num], tx_x0_rxk[cal_num],
-               tx_y0_rxk[cal_num], rx_x0[cal_num], rx_y0[cal_num];
+               tx_y0_rxk[cal_num], rx_x0[cal_num], rx_y0[cal_num],
+               tx_dt[cal_num], rx_dt[cal_num];
        bool    tx0iqkok = false, rx0iqkok = false;
        bool    vdf_enable = false;
-       int     i, k, vdf_y[3], vdf_x[3], tx_dt[3], rx_dt[3],
+       int     i, k, vdf_y[3], vdf_x[3],
                ii, dx = 0, dy = 0, tx_finish = 0, rx_finish = 0;
 
        RT_TRACE(rtlpriv, COMP_IQK, DBG_LOUD,