f2fs: remove false-positive bug_on
authorJaegeuk Kim <jaegeuk@kernel.org>
Thu, 1 Jun 2017 22:39:27 +0000 (15:39 -0700)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 4 Jul 2017 09:11:31 +0000 (02:11 -0700)
For example,

f2fs_create
 - new_node_page is failed
 - handle_failed_inode
  - skip to add it into orphan list, since ni.blk_addr == NULL_ADDR
   : set_inode_flag(inode, FI_FREE_NID)

f2fs_evict_inode
 - EIO due to fault injection
 - f2fs_bug_on() is triggered

So, we don't need to call f2fs_bug_on in this case.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/inode.c

index e53c784ab11e384866c1a7b7dce9ed39bd2fe9a1..868d71436ebc2a7bb1c6a5a06af395564edd86c3 100644 (file)
@@ -425,9 +425,10 @@ no_delete:
        if (is_inode_flag_set(inode, FI_FREE_NID)) {
                alloc_nid_failed(sbi, inode->i_ino);
                clear_inode_flag(inode, FI_FREE_NID);
+       } else {
+               f2fs_bug_on(sbi, err &&
+                       !exist_written_data(sbi, inode->i_ino, ORPHAN_INO));
        }
-       f2fs_bug_on(sbi, err &&
-               !exist_written_data(sbi, inode->i_ino, ORPHAN_INO));
 out_clear:
        fscrypt_put_encryption_info(inode, NULL);
        clear_inode(inode);