[PATCH] Fix missing parens in set_personality()
authorRussell King <rmk+lkml@arm.linux.org.uk>
Fri, 10 Nov 2006 20:27:53 +0000 (12:27 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 13 Nov 2006 15:40:42 +0000 (07:40 -0800)
If you call set_personality() with an expression such as:

set_personality(foo ? PERS_FOO1 : PERS_FOO2);

then this evaluates to:

((current->personality == foo ? PERS_FOO1 : PERS_FOO2) ? ...

which is obviously not the intended result.  Add the missing parents
to ensure this gets evaluated as expected:

((current->personality == (foo ? PERS_FOO1 : PERS_FOO2)) ? ...

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
include/linux/personality.h

index bf4cf2080e5cb1c0ba57abf88b7a85951fd0d7fb..012cd558189b443e6f3856426313cd783c6a36ce 100644 (file)
@@ -114,7 +114,7 @@ struct exec_domain {
  * Change personality of the currently running process.
  */
 #define set_personality(pers) \
-       ((current->personality == pers) ? 0 : __set_personality(pers))
+       ((current->personality == (pers)) ? 0 : __set_personality(pers))
 
 #endif /* __KERNEL__ */