USB: serial: keyspan: Fix possible null pointer dereference.
authorHuzaifa Sidhpurwala <huzaifas@redhat.com>
Mon, 21 Feb 2011 07:28:44 +0000 (12:58 +0530)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 25 Feb 2011 19:33:01 +0000 (11:33 -0800)
Signed-off-by: Huzaifa Sidhpurwala <huzaifas@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/keyspan.c

index 0791778a66f393f26c30414f3777d59410f8ed02..67f41b52657063b44da442af76ef80b809700e0a 100644 (file)
@@ -2121,16 +2121,16 @@ static int keyspan_usa49_send_setup(struct usb_serial *serial,
        /* Work out which port within the device is being setup */
        device_port = port->number - port->serial->minor;
 
-       dbg("%s - endpoint %d port %d (%d)",
-                       __func__, usb_pipeendpoint(this_urb->pipe),
-                       port->number, device_port);
-
-               /* Make sure we have an urb then send the message */
+       /* Make sure we have an urb then send the message */
        if (this_urb == NULL) {
                dbg("%s - oops no urb for port %d.", __func__, port->number);
                return -1;
        }
 
+       dbg("%s - endpoint %d port %d (%d)",
+                       __func__, usb_pipeendpoint(this_urb->pipe),
+                       port->number, device_port);
+
        /* Save reset port val for resend.
           Don't overwrite resend for open/close condition. */
        if ((reset_port + 1) > p_priv->resend_cont)