iio: inkern: fix a NULL dereference on error
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 26 Jan 2016 09:25:21 +0000 (12:25 +0300)
committerJonathan Cameron <jic23@kernel.org>
Sat, 30 Jan 2016 15:37:40 +0000 (15:37 +0000)
In twl4030_bci_probe() there are some failure paths where we call
iio_channel_release() with a NULL pointer.  (Apparently, that driver can
opperate without a valid channel pointer).  Let's fix it by adding a
NULL check in iio_channel_release().

Fixes: 2202e1fc5a29 ('drivers: power: twl4030_charger: fix link problems when building as module')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/inkern.c

index c8bad3cf891df0f1da009eeeeb1bc4809b879eda..217e9306aa0ffbe3e952554501cf6ddf362abac1 100644 (file)
@@ -351,6 +351,8 @@ EXPORT_SYMBOL_GPL(iio_channel_get);
 
 void iio_channel_release(struct iio_channel *channel)
 {
+       if (!channel)
+               return;
        iio_device_put(channel->indio_dev);
        kfree(channel);
 }