batman-adv: allow bla traffic only after first worker period
authorSimon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Sun, 9 Sep 2012 20:27:57 +0000 (22:27 +0200)
committerAntonio Quartulli <ordex@autistici.org>
Wed, 14 Nov 2012 20:00:34 +0000 (21:00 +0100)
When adding a backbone gateway for the first time, it might not yet
be known in the backbone, and therefore we should not forward
broadcasts yet. This behaviour is the same as when sending a request
to another backbone gw because of a CRC mismatch. The backbone gw
will operate normal after the next periodic bla work.

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
net/batman-adv/bridge_loop_avoidance.c

index c49cf24ab33d7c65665f560b650cf4f04e5f7d08..8cd97d59ee6178bf719381ce7988872fa0d34bef 100644 (file)
@@ -402,9 +402,14 @@ batadv_bla_get_backbone_gw(struct batadv_priv *bat_priv, uint8_t *orig,
                batadv_orig_node_free_ref(orig_node);
        }
 
-       if (own_backbone)
+       if (own_backbone) {
                batadv_bla_send_announce(bat_priv, entry);
 
+               /* this will be decreased in the worker thread */
+               atomic_inc(&entry->request_sent);
+               atomic_inc(&bat_priv->bla.num_requests);
+       }
+
        return entry;
 }
 
@@ -1138,6 +1143,19 @@ static void batadv_bla_periodic_work(struct work_struct *work)
                        backbone_gw->lasttime = jiffies;
 
                        batadv_bla_send_announce(bat_priv, backbone_gw);
+
+                       /* request_sent is only set after creation to avoid
+                        * problems when we are not yet known as backbone gw
+                        * in the backbone.
+                        *
+                        * We can reset this now and allow traffic again.
+                        */
+
+                       if (atomic_read(&backbone_gw->request_sent) == 0)
+                               continue;
+
+                       atomic_dec(&backbone_gw->bat_priv->bla.num_requests);
+                       atomic_set(&backbone_gw->request_sent, 0);
                }
                rcu_read_unlock();
        }