xfs: Fix off-by-in in loop termination in xfs_find_get_desired_pgoff()
authorJan Kara <jack@suse.cz>
Thu, 18 May 2017 23:36:23 +0000 (16:36 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 25 May 2017 16:42:25 +0000 (09:42 -0700)
There is an off-by-one error in loop termination conditions in
xfs_find_get_desired_pgoff() since 'end' may index a page beyond end of
desired range if 'endoff' is page aligned. It doesn't have any visible
effects but still it is good to fix it.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_file.c

index f1517e9928c76bab8fbe6816bfb501f5d5eeb3b5..dc0e4cb7029b2e100b2ad139561dd5541a5e83b0 100644 (file)
@@ -1043,7 +1043,7 @@ xfs_find_get_desired_pgoff(
 
        index = startoff >> PAGE_SHIFT;
        endoff = XFS_FSB_TO_B(mp, map->br_startoff + map->br_blockcount);
-       end = endoff >> PAGE_SHIFT;
+       end = (endoff - 1) >> PAGE_SHIFT;
        do {
                int             want;
                unsigned        nr_pages;