x86/microcode: Make a couple of symbols static
authorColin Ian King <colin.king@canonical.com>
Mon, 26 Jun 2017 12:35:33 +0000 (14:35 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 26 Jun 2017 13:57:37 +0000 (15:57 +0200)
The helper function __load_ucode_amd() and pointer intel_ucode_patch do
not need to be in global scope, so make them static.

Fixes those sparse warnings:
"symbol '__load_ucode_amd' was not declared. Should it be static?"
"symbol 'intel_ucode_patch' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170622095736.11937-1-colin.king@canonical.com
arch/x86/kernel/cpu/microcode/amd.c
arch/x86/kernel/cpu/microcode/intel.c

index e9f4d762aa5b5cabde501f95045fad6c43fef54b..21b185793c80ae4910b39b85a4a7ed6bc8284427 100644 (file)
@@ -251,7 +251,7 @@ static bool get_builtin_microcode(struct cpio_data *cp, unsigned int family)
 #endif
 }
 
-void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)
+static void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)
 {
        struct ucode_cpu_info *uci;
        struct cpio_data cp;
index d525a0bd7d28ba7c2201b10f29a8a326ac3224f4..59edbe9d4ccbb1500b82136a5061abb057bd333e 100644 (file)
@@ -42,7 +42,7 @@
 static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin";
 
 /* Current microcode patch used in early patching on the APs. */
-struct microcode_intel *intel_ucode_patch;
+static struct microcode_intel *intel_ucode_patch;
 
 static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
                                        unsigned int s2, unsigned int p2)